Comments on: Combining insert and update SQL logic http://www.chapter31.com/2007/04/11/combining-update-and-insert-sql-logic/ development in a land far far away... Thu, 28 Aug 2008 16:35:44 +0000 http://wordpress.org/?v=abc By: Phoenix Web Concepts » Blog Archive » Creating a dynamic stored procedure with SQL Server and ColdFusion http://www.chapter31.com/2007/04/11/combining-update-and-insert-sql-logic/#comment-17331 Phoenix Web Concepts » Blog Archive » Creating a dynamic stored procedure with SQL Server and ColdFusion Fri, 17 Aug 2007 02:58:33 +0000 http://www.chapter31.com/2007/04/11/combining-update-and-insert-sql-logic/#comment-17331 [...] stuck again. After some more searching I lucked out and found this article. If you look at the second code example you’ll see where he’s using another property of [...] [...] stuck again. After some more searching I lucked out and found this article. If you look at the second code example you’ll see where he’s using another property of [...]

]]> By: Andrew McGregor http://www.chapter31.com/2007/04/11/combining-update-and-insert-sql-logic/#comment-15506 Andrew McGregor Wed, 25 Jul 2007 05:47:12 +0000 http://www.chapter31.com/2007/04/11/combining-update-and-insert-sql-logic/#comment-15506 For MySQL users there is the REPLACE INTO command (to replace INSERT INTO statements). This looks for matching rows with the same unique keys and deletes them before adding the new row. For MySQL users there is the REPLACE INTO command (to replace INSERT INTO statements). This looks for matching rows with the same unique keys and deletes them before adding the new row.

]]> By: Michael Sharman http://www.chapter31.com/2007/04/11/combining-update-and-insert-sql-logic/#comment-6105 Michael Sharman Wed, 11 Apr 2007 23:35:07 +0000 http://www.chapter31.com/2007/04/11/combining-update-and-insert-sql-logic/#comment-6105 Hi Chip, I see what you're saying, what I was getting at in the example though was avoiding having that logic in your application code. The example I used could easily return SCOPE_IDENTITY from the stored proc as well, thanks for that! Hi Chip,

I see what you’re saying, what I was getting at in the example though was avoiding having that logic in your application code.

The example I used could easily return SCOPE_IDENTITY from the stored proc as well, thanks for that!

]]> By: Michael Sharman http://www.chapter31.com/2007/04/11/combining-update-and-insert-sql-logic/#comment-6104 Michael Sharman Wed, 11 Apr 2007 23:30:02 +0000 http://www.chapter31.com/2007/04/11/combining-update-and-insert-sql-logic/#comment-6104 Hi Tony, I didn't know this was the case, but reading the link you provided doesn't hold up for me. - Structual changes are not being made - Not using WITH RECOMPILE - Not using large amounts of INSERT, UPDATE or DELETE I haven't come across anything which states that using conditional logic inside a SP will make it recompile on every execution. The following was from <a href="http://msdn2.microsoft.com/en-us/library/aa174792(SQL.80).aspx" rel="nofollow">MSDN</a> (for MSSQL2000): "If these SQL statements and conditional logic are written into a stored procedure, they become part of a single execution plan on the server." Mind you I haven't used the Profiler on this to try and capture when the SP is recompiling :) Maybe that's my next step. Hi Tony,

I didn’t know this was the case, but reading the link you provided doesn’t hold up for me.

- Structual changes are not being made
- Not using WITH RECOMPILE
- Not using large amounts of INSERT, UPDATE or DELETE

I haven’t come across anything which states that using conditional logic inside a SP will make it recompile on every execution.

The following was from MSDN (for MSSQL2000):

“If these SQL statements and conditional logic are written into a stored procedure, they become part of a single execution plan on the server.”

Mind you I haven’t used the Profiler on this to try and capture when the SP is recompiling :)

Maybe that’s my next step.

]]> By: Qasim Rasheed http://www.chapter31.com/2007/04/11/combining-update-and-insert-sql-logic/#comment-6089 Qasim Rasheed Wed, 11 Apr 2007 21:22:56 +0000 http://www.chapter31.com/2007/04/11/combining-update-and-insert-sql-logic/#comment-6089 Oracle has nice feature named Merge aka Upsert that make this a breeze. Here is a url that explain it usage. http://www.psoug.org/reference/merge.html Thanks Oracle has nice feature named Merge aka Upsert that make this a breeze. Here is a url that explain it usage.

http://www.psoug.org/reference/merge.html

Thanks

]]> By: Chip Temm http://www.chapter31.com/2007/04/11/combining-update-and-insert-sql-logic/#comment-6088 Chip Temm Wed, 11 Apr 2007 21:12:10 +0000 http://www.chapter31.com/2007/04/11/combining-update-and-insert-sql-logic/#comment-6088 Good idea. A couple of notes. If you are wrapping this in a CFC function, you could handle what Tony talks about inside the function, calling different SPs inside the function depending on whether a myprimarykey is passed. I would recommend that such a function always return the primarykey value because after successful execution, you will always have one. For SQL server, you could use the following to return this from your insert: IF (@myPrimaryKey Is Null) BEGIN --no record exists so run an INSERT statement INSERT INTO myTable(FirstName, LastName, Email, Age) VALUES (@firstName, @lastName, @email, @age) SELECT SCOPE_IDENTITY() END Good idea. A couple of notes.
If you are wrapping this in a CFC function, you could handle what Tony talks about inside the function, calling different SPs inside the function depending on whether a myprimarykey is passed.

I would recommend that such a function always return the primarykey value because after successful execution, you will always have one.

For SQL server, you could use the following to return this from your insert:
IF (@myPrimaryKey Is Null)
BEGIN
–no record exists so run an INSERT statement
INSERT INTO myTable(FirstName, LastName, Email, Age)
VALUES (@firstName, @lastName, @email, @age)

SELECT SCOPE_IDENTITY()
END

]]> By: jim collins http://www.chapter31.com/2007/04/11/combining-update-and-insert-sql-logic/#comment-6066 jim collins Wed, 11 Apr 2007 17:28:01 +0000 http://www.chapter31.com/2007/04/11/combining-update-and-insert-sql-logic/#comment-6066 Another approach is to do an update, run select @@ as recordsUpdated , check the value of recordsupdated, and if it's 0 , do an insert. This is similar to the Oracle Upsert concept. Another approach is to do an update, run select @@ as recordsUpdated , check the value of recordsupdated, and if it’s 0 , do an insert. This is similar to the Oracle Upsert concept.

]]> By: tony petruzzi http://www.chapter31.com/2007/04/11/combining-update-and-insert-sql-logic/#comment-6042 tony petruzzi Wed, 11 Apr 2007 14:04:10 +0000 http://www.chapter31.com/2007/04/11/combining-update-and-insert-sql-logic/#comment-6042 you do realize that by having a conditional statement inside your stored procedure (SP) you negate the benefits of using a SP since it will be recompiled on every execution. This page has more information: http://www.databasejournal.com/features/mssql/article.php/1565961 The proper way is to break down your SP into smaller SPs and having the main SP call them. In your example, you would create 3 SPs. One for the insert, one for the update and the main that would call the insert or update SP. This would give you better performance since the insert and update SPs wouldn't be recompiled only the main one would. you do realize that by having a conditional statement inside your stored procedure (SP) you negate the benefits of using a SP since it will be recompiled on every execution.

This page has more information:
http://www.databasejournal.com/features/mssql/article.php/1565961

The proper way is to break down your SP into smaller SPs and having the main SP call them. In your example, you would create 3 SPs. One for the insert, one for the update and the main that would call the insert or update SP. This would give you better performance since the insert and update SPs wouldn’t be recompiled only the main one would.

]]>